bitcoind: fix raw TX fetching when using REST - #1006
Merged
Conversation
|
I've assigned @tnull as a reviewer! |
tnull
reviewed
Jul 28, 2026
tnull
left a comment
tnull
left a comment
Collaborator
There was a problem hiding this comment.
Thanks, good catch!
While you're here, mind adding a second commit that changes the range in random_chain_source to also cover the REST arm (i.e. should use 0..4 I believe), which would give us improved test coverage for the REST chain source?
tnull
approved these changes
Aug 5, 2026
tnull
left a comment
tnull
left a comment
Collaborator
There was a problem hiding this comment.
Thanks!
The CI change showed that we have another bug in the REST client implementation. Landing this and working on a fix for it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed this issue while testing switching my nodes from the Electrum ChainSource to bitcoind.
An alternate fix here would also be to fetch the TX as binary instead of JSON - I can put up a PR for that if that's preferred.